Skip to content

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Aug 26, 2024

A general clean-up of the CoreGraphics implementation, instead of creating a new NSView and rendering into the layer there, we create a sublayer. See the code comments, and also gfx-rs/wgpu#6107 for some of the design decisions around this.

This is also a step forwards for making softbuffer usable from a separate thread on Apple platforms, as CALayer is fully thread safe (whereas NSView/UIView aren't).

Finally, it removes our dependence on having access to NSView, paving the way for a future where raw-window-handle may only provide CALayer.

Fixes #43.

@madsmtm madsmtm added enhancement New feature or request CoreGraphics macOS/iOS/tvOS/watchOS/visionOS backend labels Aug 26, 2024
@madsmtm madsmtm requested a review from john01dav as a code owner August 26, 2024 01:54
@madsmtm madsmtm requested review from notgull and removed request for john01dav August 26, 2024 01:54
@madsmtm madsmtm force-pushed the ios branch 3 times, most recently from dcf429b to bbcfcaf Compare September 1, 2024 05:00
Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed on a Rust level.

Probably update the README as well.

@madsmtm madsmtm merged commit dc4ae44 into master Sep 4, 2024
38 checks passed
@madsmtm madsmtm deleted the ios branch September 4, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CoreGraphics macOS/iOS/tvOS/watchOS/visionOS backend enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

iOS platform

2 participants